pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-06-12 14:14:48 +02:00
Code Activity

irc: use parsed command parameters in "wallops" command callback

Browse Source
This commit is contained in:
Sébastien Helleu
2021-10-15 19:25:43 +02:00
parent 7c1ea1cb32
commit ec816b4be5
2 changed files with 15 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/plugins/irc/irc-protocol.c
+10 -3
View File
@@ -3320,19 +3320,23 @@ IRC_PROTOCOL_CALLBACK(topic)
* Callback for the IRC command "WALLOPS".
*
* Command looks like:
* :nick!user@host WALLOPS :message from admin
* WALLOPS :message from admin
*/
IRC_PROTOCOL_CALLBACK(wallops)
{
const char *nick_address;
char *str_params;
IRC_PROTOCOL_MIN_ARGS(3);
IRC_PROTOCOL_MIN_PARAMS(1);
if (ignored)
return WEECHAT_RC_OK;
nick_address = irc_protocol_nick_address (server, 0, NULL, nick, address);
str_params = irc_protocol_string_params (params, 0, num_params - 1);
weechat_printf_date_tags (
irc_msgbuffer_get_target_buffer (server, nick, command, NULL, NULL),
date,
@@ -3340,7 +3344,10 @@ IRC_PROTOCOL_CALLBACK(wallops)
_("%sWallops from %s: %s"),
weechat_prefix ("network"),
(nick_address[0]) ? nick_address : "?",
(argv_eol[2][0] == ':') ? argv_eol[2] + 1 : argv_eol[2]);
str_params);
if (str_params)
free (str_params);
return WEECHAT_RC_OK;
}
tests/unit/plugins/irc/test-irc-protocol.cpp
+5 -2
View File
@@ -1927,9 +1927,12 @@ TEST(IrcProtocolWithServer, wallops)
{
SRV_INIT;
/* not enough arguments */
/* not enough parameters */
RECV(":alice!user@host WALLOPS");
CHECK_ERROR_ARGS("wallops", 2, 3);
CHECK_ERROR_PARAMS("wallops", 0, 1);
RECV(":alice!user@host WALLOPS message");
CHECK_SRV("-- Wallops from alice (user@host): message");
RECV(":alice!user@host WALLOPS :message from admin");
CHECK_SRV("-- Wallops from alice (user@host): message from admin");