pegasus/weechat
1
0
Fork 0
mirror of https://github.com/weechat/weechat.git synced 2026-06-26 21:06:38 +02:00
Code Activity

tests: Use LONGS_EQUAL for version number tests

Browse Source 
util_version_number returns an int, but BYTES_EQUAL only compares the
last byte of the int, so it wouldn't test the rest of the int.

I see other tests for functions returning an int use LONGS_EQUAL, so
that seems correct to use.
This commit is contained in:
Trygve Aaberge
2022-10-08 17:42:22 +02:00
committed by Sébastien Helleu
parent 193aa0448f
commit fdb1ff3781
1 changed files with 15 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/unit/core/test-core-util.cpp
+15 -15
View File
@@ -229,19 +229,19 @@ TEST(CoreUtil, ParseDelay)
TEST(CoreUtil, VersionNumber)
{
BYTES_EQUAL(0x00030200, util_version_number ("0.3.2-dev"));
BYTES_EQUAL(0x00030200, util_version_number ("0.3.2-rc1"));
BYTES_EQUAL(0x00030200, util_version_number ("0.3.2"));
BYTES_EQUAL(0x00030101, util_version_number ("0.3.1.1"));
BYTES_EQUAL(0x00030100, util_version_number ("0.3.1"));
BYTES_EQUAL(0x00030000, util_version_number ("0.3.0"));
BYTES_EQUAL(0x01000000, util_version_number ("1.0"));
BYTES_EQUAL(0x01000000, util_version_number ("1.0.0"));
BYTES_EQUAL(0x01000000, util_version_number ("1.0.0.0"));
BYTES_EQUAL(0x01000100, util_version_number ("1.0.1"));
BYTES_EQUAL(0x01000200, util_version_number ("1.0.2"));
BYTES_EQUAL(0x01010000, util_version_number ("1.1"));
BYTES_EQUAL(0x01010100, util_version_number ("1.1.1"));
BYTES_EQUAL(0x01010200, util_version_number ("1.1.2"));
BYTES_EQUAL(0x01020304, util_version_number ("1.2.3.4"));
LONGS_EQUAL(0x00030200, util_version_number ("0.3.2-dev"));
LONGS_EQUAL(0x00030200, util_version_number ("0.3.2-rc1"));
LONGS_EQUAL(0x00030200, util_version_number ("0.3.2"));
LONGS_EQUAL(0x00030101, util_version_number ("0.3.1.1"));
LONGS_EQUAL(0x00030100, util_version_number ("0.3.1"));
LONGS_EQUAL(0x00030000, util_version_number ("0.3.0"));
LONGS_EQUAL(0x01000000, util_version_number ("1.0"));
LONGS_EQUAL(0x01000000, util_version_number ("1.0.0"));
LONGS_EQUAL(0x01000000, util_version_number ("1.0.0.0"));
LONGS_EQUAL(0x01000100, util_version_number ("1.0.1"));
LONGS_EQUAL(0x01000200, util_version_number ("1.0.2"));
LONGS_EQUAL(0x01010000, util_version_number ("1.1"));
LONGS_EQUAL(0x01010100, util_version_number ("1.1.1"));
LONGS_EQUAL(0x01010200, util_version_number ("1.1.2"));
LONGS_EQUAL(0x01020304, util_version_number ("1.2.3.4"));
}