Version 4.5.1

This fixes the following error with `/upgrade` command when relay clients are
connected:

  relay: failed to save upgrade data

.github/workflows/ci.yml

@@ -381,9 +381,7 @@ jobs:
           /usr/local/bin/python3.11 \
           /usr/local/bin/python3.11-config \
         ;
-        # workaround for https://github.com/actions/runner-images/issues/10984
-        brew uninstall --ignore-dependencies --force pkg-config@0.29.2
-        brew install asciidoctor aspell cjson guile lua ruby
+        brew install asciidoctor aspell cjson guile lua pkg-config ruby
 
     - uses: actions/checkout@v4
 

CHANGELOG.md

@@ -1,5 +1,15 @@
 # WeeChat ChangeLog
 
+## Version 4.5.1 (2024-12-23)
+
+### Fixed
+
+- relay: fix crash after `/upgrade` when relay clients are connected
+- api: fix creation of empty buffer in function infolist_new_var_buffer
+- core: fix detection of dl library ([#2218](https://github.com/weechat/weechat/issues/2218))
+- logger: fix path displayed when the logs directory can not be created
+- perl: fix build with Perl < 5.7.29 ([#2219](https://github.com/weechat/weechat/issues/2219), [#2220](https://github.com/weechat/weechat/issues/2220))
+
 ## Version 4.5.0 (2024-12-15)
 
 ### Changed

CMakeLists.txt

@@ -247,9 +247,7 @@ find_library(DL_LIBRARY
   PATHS /lib /usr/lib /usr/libexec /usr/local/lib /usr/local/libexec
 )
 if(DL_LIBRARY)
-  string(REGEX REPLACE "/[^/]*$" "" DL_LIBRARY_PATH "${DL_LIBRARY}")
-  set(CMAKE_C_LINK_FLAGS "${CMAKE_C_LINK_FLAGS} -L${DL_LIBRARY_PATH}")
-  list(APPEND EXTRA_LIBS dl)
+  list(APPEND EXTRA_LIBS ${DL_LIBRARY})
 endif()
 
 add_subdirectory(icons)

src/core/core-infolist.c

@@ -247,17 +247,27 @@ infolist_new_var_buffer (struct t_infolist_item *item,
 {
     struct t_infolist_var *new_var;
 
-    if (!item || !name || !name[0] || (size <= 0))
+    if (!item || !name || !name[0])
         return NULL;
 
+    if (size < 0)
+        size = 0;
+
     new_var = malloc (sizeof (*new_var));
     if (new_var)
     {
         new_var->name = strdup (name);
         new_var->type = INFOLIST_BUFFER;
-        new_var->value = malloc (size);
-        if (new_var->value)
-            memcpy (new_var->value, pointer, size);
+        if (pointer && (size > 0))
+        {
+            new_var->value = malloc (size);
+            if (new_var->value)
+                memcpy (new_var->value, pointer, size);
+        }
+        else
+        {
+            new_var->value = NULL;
+        }
         new_var->size = size;
 
         new_var->prev_var = item->last_var;

src/gui/curses/normal/CMakeLists.txt

@@ -72,6 +72,7 @@ target_link_libraries(${EXECUTABLE}
 # It may be removed in future.
 add_custom_command(
   TARGET ${EXECUTABLE}
+  POST_BUILD
   COMMAND ${CMAKE_COMMAND} -E remove -f "weechat-curses${CMAKE_EXECUTABLE_SUFFIX}"
   COMMAND ${CMAKE_COMMAND} -E create_symlink "weechat${CMAKE_EXECUTABLE_SUFFIX}" "weechat-curses${CMAKE_EXECUTABLE_SUFFIX}"
   WORKING_DIRECTORY "${CMAKE_CURRENT_BINARY_DIR}"

src/plugins/logger/logger-buffer.c

@@ -265,15 +265,7 @@ logger_buffer_create_log_file (struct t_logger_buffer *logger_buffer)
 
     /* create directory */
     if (!logger_create_directory ())
-    {
-        weechat_printf_date_tags (
-            NULL, 0, "no_log",
-            _("%s%s: unable to create directory for logs "
-              "(\"%s\")"),
-            weechat_prefix ("error"), LOGGER_PLUGIN_NAME,
-            weechat_config_string (logger_config_file_path));
         return 0;
-    }
     if (!logger_buffer->log_filename)
         logger_buffer_set_log_filename (logger_buffer);
     if (!logger_buffer->log_filename)

src/plugins/logger/logger.c

@@ -182,7 +182,15 @@ logger_create_directory ()
     if (file_path)
     {
         if (!weechat_mkdir_parents (file_path, 0700))
+        {
+            weechat_printf_date_tags (
+                NULL, 0, "no_log",
+                _("%s%s: unable to create directory for logs "
+                  "(\"%s\")"),
+                weechat_prefix ("error"), LOGGER_PLUGIN_NAME,
+                file_path);
             rc = 0;
+        }
         free (file_path);
     }
     else

src/plugins/perl/weechat-perl.c

@@ -579,11 +579,15 @@ weechat_perl_load (const char *filename, const char *code)
     wcwidth160 = wcwidth (160);
     perl_construct (perl_current_interpreter);
 
+#if PERL_REVISION >= 6 || (PERL_REVISION == 5 && PERL_VERSION >= 28) || (PERL_REVISION == 5 && PERL_VERSION == 27 && PERL_SUBVERSION >= 9)
     if (wcwidth (160) != wcwidth160)
     {
         /* restore the locale that's broken in some versions of Perl */
         Perl_setlocale (LC_ALL, "");
     }
+#else
+    (void) wcwidth160;
+#endif
 
     temp_script.interpreter = (PerlInterpreter *) perl_current_interpreter;
     perl_parse (perl_current_interpreter, weechat_perl_api_init,
@@ -1320,11 +1324,15 @@ weechat_plugin_init (struct t_weechat_plugin *plugin, int argc, char *argv[])
     wcwidth160 = wcwidth (160);
     perl_construct (perl_main);
 
+#if PERL_REVISION >= 6 || (PERL_REVISION == 5 && PERL_VERSION >= 28) || (PERL_REVISION == 5 && PERL_VERSION == 27 && PERL_SUBVERSION >= 9)
     if (wcwidth (160) != wcwidth160)
     {
         /* restore the locale that's broken in some versions of Perl */
         Perl_setlocale (LC_ALL, "");
     }
+#else
+    (void) wcwidth160;
+#endif
 
     perl_parse (perl_main, weechat_perl_api_init, perl_args_count,
                 perl_args, NULL);

src/plugins/relay/relay-client.c

@@ -1589,7 +1589,8 @@ relay_client_new_with_infolist (struct t_infolist *infolist)
     if (new_client)
     {
         new_client->id = weechat_infolist_integer (infolist, "id");
-        new_client->desc = NULL;
+        str = weechat_infolist_string (infolist, "desc");
+        new_client->desc = (str) ? strdup (str) : NULL;
         new_client->sock = weechat_infolist_integer (infolist, "sock");
         new_client->server_port = weechat_infolist_integer (infolist, "server_port");
         /* "tls" replaces "ssl" in WeeChat 4.0.0 */
@@ -1696,6 +1697,11 @@ relay_client_new_with_infolist (struct t_infolist *infolist)
                 new_client->partial_ws_frame_size = ws_frame_size;
             }
         }
+        else
+        {
+            new_client->partial_ws_frame = NULL;
+            new_client->partial_ws_frame_size = 0;
+        }
         str = weechat_infolist_string (infolist, "partial_message");
         new_client->partial_message = (str) ? strdup (str) : NULL;
 

version.sh

@@ -39,8 +39,8 @@
 #     devel-number   the devel version as hex number ("0x04010000" for "4.1.0-dev")
 #
 
-weechat_stable="4.5.0"
-weechat_devel="4.5.0"
+weechat_stable="4.5.1"
+weechat_devel="4.5.1"
 
 stable_major=$(echo "${weechat_stable}" | cut -d"." -f1)
 stable_minor=$(echo "${weechat_stable}" | cut -d"." -f2)