Bram Matthys
fa875d6fd4
Cleanup: register_user() now takes only 1 argument (client) instead of 5 arguments.
...
The last 3 were always NULL after the remote/local split from a few commits ago.
And nick and username were useless as well as client->name and
client->user->username were always already set.
2021-08-13 11:06:30 +02:00
Bram Matthys
77a7b3aca2
More cleanups in nick.c: integrate register_user_remote() in cmd_uid()
2021-08-13 10:57:54 +02:00
Bram Matthys
33db820355
More nick.c (register user) cleanups..
2021-08-13 10:49:45 +02:00
Bram Matthys
75a7d171b9
Test buildbot
2021-08-13 10:40:53 +02:00
Bram Matthys
8ca735a217
Split remote register_user() off into register_user_remote(),
...
which may or may not disappear in a future cleanup.
2021-08-13 10:23:50 +02:00
Bram Matthys
f90c7a7991
Move IP validation from register_user() to cmd_uid().
...
This also makes it so the decoded IP is passed to register_user(),
eg "1.2.3.4" instead of binary base64'd stuff.
2021-08-12 20:09:24 +02:00
Bram Matthys
5eb2ac7624
Fix OperOverride message
2021-08-12 17:56:23 +02:00
Bram Matthys
9a2e8613ae
For remotely received log messages (via SLOG) show the original server name
...
as sender in the NOTICE, just like we used to do in the past.
2021-08-12 17:07:12 +02:00
Bram Matthys
0e5f5f7374
Add conf/snomasks.default.conf
2021-08-12 16:58:54 +02:00
Bram Matthys
9f54c9b0d3
Don't send SAPART in SAJOIN (:D)
2021-08-12 16:51:18 +02:00
Bram Matthys
152d24bd73
Don't check for "chathistory" capability yet (only "draft/chathistory")
...
as this casuses BUG_CLIENTCAPABILITYBIT_UNKNOWN_TOKEN to be triggered.
2021-08-12 16:33:31 +02:00
Bram Matthys
60d970d9af
And another fix for previous case.
2021-08-12 16:16:09 +02:00
Bram Matthys
5cc2ef7fba
Newlog: free arguments, even if unreal_log_recursion_trap is hit
...
This was triggered for example when sending logs to remote servers.
2021-08-12 16:11:02 +02:00
Bram Matthys
16527eb6a4
Back out previous change, bad idea :D
2021-08-12 16:03:20 +02:00
Bram Matthys
507f43fc74
Set me.uplink to &me. Not entirely sure if this is what we want.
...
Without this, I think otherwise we need too many checks everywhere
for the IsMe() case. And this behavior matches me.direction which
also points to &me.
Then again, will doing it this way cause issues? We will see...
2021-08-12 15:57:58 +02:00
Bram Matthys
bb4d77b5d0
Fix crash in link-security unreal_log() call..
...
Interesting... this mistake is easy to make with multiline.
2021-08-12 15:43:26 +02:00
Bram Matthys
cc6d1eaf36
Don't crash on bad loglevel/subsystem/event_id but log it instead.
2021-08-12 15:43:03 +02:00
Bram Matthys
689c089a41
Allow dashes in subsystem (eg "link-security")
2021-08-12 15:30:50 +02:00
Bram Matthys
445b47391f
Do an #undef on LOG_DEBUG, LOG_INFO, etc.. so they cannot be confused
...
anymore with the ULOG_DEBUG, ULOG_INFO, etc levels.
2021-08-12 15:27:27 +02:00
Bram Matthys
579988e07e
ULOG_INFO, not LOG_INFO, strikes again!
2021-08-12 15:23:07 +02:00
Bram Matthys
b48d7f8003
Fix for vhost checking code in cmd_uid, which didn't take into account '*' (no vhost set)
2021-08-12 15:20:14 +02:00
Bram Matthys
7f55159f77
Fix memory leak in new log code
2021-08-12 15:18:18 +02:00
Bram Matthys
8d72aaa0ad
Checkout branch 'unreal60' from unrealircd-tests
2021-08-12 15:16:37 +02:00
Bram Matthys
562ed345be
Update unrealircd-tests repo URL, temporarily used during early U6 development.
2021-08-12 15:08:19 +02:00
Bram Matthys
01753c67cd
Validate hostname and vhost in UID command. And some very minor cleanups.
2021-08-12 09:13:02 +02:00
Bram Matthys
3a752a60fa
Fix a remaining instance where client->local->fake_lag was touched
...
directly, should use add_fake_lag(client, msec) instead.
2021-08-12 08:56:46 +02:00
Bram Matthys
be6928df78
Some cleanups in nick.c
2021-08-12 08:55:46 +02:00
Bram Matthys
d9c940f65d
Update client->flags inheritance code in register_user().
...
Hopefully correct... if this or ulines inheritance break you know
who did it ;)
2021-08-12 08:38:14 +02:00
Bram Matthys
f9086f700e
Newlog: nick.c
2021-08-12 08:37:54 +02:00
Bram Matthys
f84dd51172
Newlog: link-security, mkpasswd, mode
2021-08-11 21:08:49 +02:00
Bram Matthys
7a4509b289
Newlog: "New record on this server: $num_users connections"
...
And also make this print the number of users and not (both) users+servers
which is generally a metric nobody is interested in and only causes
confusion when you get a message about a record of 30 and there are only
28 clients connected.
2021-08-11 20:55:42 +02:00
Bram Matthys
2c374395aa
Newlog: Use _DENIED instead of _REJECTED everywhere to be consistent,
...
eg LINK_REJECTED_SID_COLLISION -> LINK_DENIED_SID_COLLISION
since 15+ other ones also start with LINK_DENIED...
Expand it to other areas as well eg antirandom.
2021-08-11 20:48:50 +02:00
Bram Matthys
720cd84ab2
Newlog: convert sendto_realops() to unreal_log() in 9 files.
2021-08-11 20:47:18 +02:00
Bram Matthys
a94017c731
Remove sendto_ops_and_log(), use unreal_log() instead!
2021-08-11 19:10:30 +02:00
Bram Matthys
edfd0d434f
Newlog: convert remaining sendto_ops_and_log()
2021-08-11 19:09:07 +02:00
Bram Matthys
ccfad0eed0
Enable high CPU usage detection, not sure yet for production, but
...
at least for U6 development.
2021-08-11 19:08:46 +02:00
Bram Matthys
609a6600aa
Remove ircd_log(), use unreal_log() instead!
2021-08-11 18:01:00 +02:00
Bram Matthys
4968bf84fe
Newlog: convert those in include/*.h too
2021-08-11 17:59:40 +02:00
Bram Matthys
4198b380f4
Newlog: convert the last ones to ircd_log
2021-08-11 17:55:15 +02:00
Bram Matthys
8d2f20ef41
Newlog: debug.c, match.c, module.c, random.c and then for
...
api-*.c log out of space in all circumstances.
2021-08-11 17:45:01 +02:00
Bram Matthys
ca3c91ca17
Newlog: channel.c, send.c, support.c, windows/gui.c
2021-08-11 17:12:11 +02:00
Bram Matthys
11755b2093
Some variable renaming in start_listeners()
2021-08-11 16:48:44 +02:00
Bram Matthys
9333d4b264
Newlog: fdlist.c, socket.c
2021-08-11 16:48:26 +02:00
Bram Matthys
82f9dc6355
Newlog: misc.c
2021-08-11 16:42:04 +02:00
Bram Matthys
191f81dd63
Newlog: dispatch (io engine)
...
Hopefully no typos anywhere, since the compiler only checks about 1/3rd
of the code since it depends on the backend which code is used.
2021-08-11 16:03:54 +02:00
Bram Matthys
fe21fd6024
Remove sendto_realops_and_log() and map some remaining temporary
...
to sendto_ops_and_log() which will soon disappear too.
2021-08-11 15:47:00 +02:00
Bram Matthys
9a620ef687
Newlog: make "Channel modes changed at runtime", "User modes changed at runtime"
...
match the "Permitted nick characters changed at runtime" log message.
2021-08-11 15:44:26 +02:00
Bram Matthys
9308e5b8a0
Change maximum chanmode +l value to 1 million and "coincidentally" also
...
change the IsInvalidChannelTS() macro to check for this value or lower.
2021-08-11 15:39:15 +02:00
Bram Matthys
9efe590a8e
Newlog and fishy timestamp handling:
...
* New macro IsInvalidChannelTS() which evaluates to ts < 750000
* Check for faulty creation time ("fishy timestamp") at ALL places
where channel->creationtime is set.
* Also, important, changed behavior:
if !IsInvalidChannelTS then:
1) We print our warning
2) We pretend ts is our channel creationtime (which may be
TStime() if the channel did not previously exist)
3) We allow the command through and allow it to merge (in case of SJOIN)
This makes it so we still log the error (noisy) but on the other hand
we won't get "infected" by fishy timestamps since we will never set
them, no matter what happens.
2021-08-11 15:29:45 +02:00
Bram Matthys
471a97c5f6
Newlog: md, monitor, targetfloodprot, watch-backend, watch
2021-08-11 15:11:24 +02:00