Bram Matthys
5092fa985d
We already allow users in after 10 seconds if CBL is too slow, and that part worked correctly. However 5 seconds later, when the URL API 15 second timeout hits, it would try to allow the user in AGAIN. This caused the user to be introduced twice, causing remote servers to kill the user, and also screwing up user counts. Reported by multiple people, including Jellis who actually filed a report with logs, and alice providing logs as well, all when CBL was temporarily down for a few hours in August 2024. In hindsight this bug was already reported by k4be back in November 2023 but was more rare at the time and mistaken for another very similar bug that was fixed in 6.1.3. With this patch, we check before we call cbl_allow(), but also cbl_allow() itself checks the "user already allowed in?". Oh yeah and this is hot patchable, within the hour I will make this work: ./unrealircd hot-patch cbl-timeout-fix
About UnrealIRCd
UnrealIRCd is an Open Source IRC Server, serving thousands of networks since 1999. It runs on Linux, OS X and Windows and is currently the most widely deployed IRCd with a market share of 38%. UnrealIRCd is a highly advanced IRCd with a strong focus on modularity and security. It uses an advanced and highly configurable configuration file. Other key features include: full IRCv3 support, SSL/TLS, cloaking, advanced anti-flood and anti-spam systems, GeoIP, remote includes, and lots of other features. We are also particularly proud on our extensive online documentation.
Versions
- UnrealIRCd 6 is the stable series since December 2021. It is the only supported version.
- For full details of release scheduling and EOL dates, see UnrealIRCd releases on the wiki
How to get started
Follow the installation guide on the wiki. See:
Documentation & FAQ
You can find all documentation online at: https://www.unrealircd.org/docs/
We also have a good FAQ: https://www.unrealircd.org/docs/FAQ
Website, support, and other links
- https://www.unrealircd.org - Our main website
- https://forums.unrealircd.org - Support
- https://bugs.unrealircd.org - Bug tracker
- ircs://irc.unrealircd.org:6697/unreal-support - IRC support